Switch from jose to cloudflare-worker-jwt#33
Closed
skaldebane wants to merge 2 commits intofinsweet:masterfrom
Closed
Switch from jose to cloudflare-worker-jwt#33skaldebane wants to merge 2 commits intofinsweet:masterfrom
jose to cloudflare-worker-jwt#33skaldebane wants to merge 2 commits intofinsweet:masterfrom
Conversation
Member
|
I just updated the |
Author
|
Sorry for the late response, as I don't use Firebase anymore, and kept delaying this forever 😅 Just tried the latest version on a dummy project, and it works perfectly, without needing any hacks! |
Member
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had many issues with
fireworkerswith Cloudflare Pages (in a SvelteKit project).At build time (on deployment), the build fails due to lack of
CryptoKey, which is extremely weird.However, I found a workaround inspired by panva/jose#411 (not included in this PR), by polyfilling
CryptoKeyfrom@peculiar/webcryptobefore callingFireworkers.init(...).However, this fix only works when using
@tsndr/cloudflare-worker-jwt, whilejosecomplains aboutCryptoKeynot being the same as the one it expects.I'm currently using this version in a real app and it works flawlessly.
While
joseshould normally work just fine on any environment,cloudflare-worker-jwtis a pretty solid replacement, especially thatfireworkersis targeting Cloudflare Workers specifically.Maybe I'm missing something here, so it's okay if you refuse this change!